Skip to content

Omitted tests should be reported as <skipped> #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MariuszCwikla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Omitted tests should be reported as <skipped> #11

MariuszCwikla wants to merge 1 commit into from
+16 −2

Conversation

@MariuszCwikla
Copy link

@MariuszCwikla MariuszCwikla commented Feb 25, 2019

Following test

def test_omit    
  omit 'omitted'
end

is reported as

<testcase name="test_omit" time="0.000373181" assertions="0">
    <failure type="Test::Unit::Omission" message="omitted">...</failure>
</testcase>

but it should be reported as <skipped> instead of <failure>

Simple fix is to set up skipped flag ci-reporter's TestCase which was not used in ci_reporter_test_unit yet

@MariuszCwikla MariuszCwikla force-pushed the omit-reported-as-failure branch from 42ae42a to 8815543 Compare February 27, 2019 17:20
@MariuszCwikla MariuszCwikla mentioned this pull request Feb 27, 2019
Open
@MariuszCwikla
Copy link
Author

MariuszCwikla commented Oct 10, 2019

@nicksieger @shepmaster any update regarding this?
Please check also #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MariuszCwikla